Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator Redesign #216

Merged
merged 27 commits into from
Sep 20, 2023
Merged

Operator Redesign #216

merged 27 commits into from
Sep 20, 2023

Conversation

astefanutti
Copy link
Contributor

@astefanutti astefanutti commented Aug 8, 2023

Part of #279.

Closes #281.

@astefanutti
Copy link
Contributor Author

/hold

@astefanutti
Copy link
Contributor Author

/assign @anishasthana @KPostOffice @sutaakar

config/rbac/role.yaml Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
pkg/config/config.go Show resolved Hide resolved
Copy link
Collaborator

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just a couple of questions

test/e2e/setup.sh Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@sutaakar
Copy link
Contributor

Looks good to me once comments are addressed

@astefanutti
Copy link
Contributor Author

/unhold

Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm from my perspective. We can merge it once @KPostOffice and @sutaakar have approved it. (I'm not approving it myself as that would result in the PR merging)

@anishasthana
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 19, 2023
@KPostOffice
Copy link
Collaborator

this /lgtm as well

@sutaakar
Copy link
Contributor

/lgtm

Copy link
Contributor

@dimakis dimakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

great work Antonin
the e2e tests fail for me locally but seen to pass in the CI so it may just be my env

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Initialise and source configuration from a ConfigMap
6 participants